Upgrade to Scala.js 1.0.0-RC1 #106
Conversation
build.sbt
Outdated
| previousArtifact := { | ||
| val previousArtifactSetting = Def.settings() | ||
| /* MiMa is completely disabled while we are in 1.0.0-SNAPSHOT. | ||
| mimaPreviousArtifacts ++= { | ||
| val scalaV = scalaVersion.value | ||
| val scalaBinaryV = scalaBinaryVersion.value | ||
| if (!scalaVersionsUsedForPublishing.contains(scalaV)) { |
There was a problem hiding this comment.
Since you removed scalaVersionsUsedForPublishing, perhaps also remove this test?
seleniumJSEnv/src/main/scala/org/scalajs/jsenv/selenium/SeleniumRun.scala
Outdated
Show resolved
Hide resolved
They are deprecated in Scala 2.13.
|
Updated (fix in |
| @@ -24,7 +22,7 @@ class KeepAliveTest { | |||
| def quit(): Unit = closed = true | |||
|
|
|||
| def executeScript(code: String, args: Object*): Object = | |||
| Map.empty[String, String].asJava | |||
| new java.util.HashMap[String, java.util.List[String]]() | |||
There was a problem hiding this comment.
Hum, why did the type of values change from String to java.util.List[String]?
There was a problem hiding this comment.
Was a bug :) But it's of course not distinguishable for an empty map...
|
Fixed another omission in the scala version upgrade commit: There were unnecessary if blocks. |
|
Also see: scala-js/scala-js#3884 |
There was a problem hiding this comment.
The suggested changes below should bring the new code closer to the semantics of the old code, which I suppose should fix the broken tests.
Also I would remove the following sentence from the commit message:
This surfaces in 2.13 where takeRight seems to not be optimized.
or at least change it so that it doesn't assume what is not confirmed:
This surfaces in 2.13 where takeRight seems to be compiled differently.
| val h1 = elements(0) | ||
| // Nodes start at 2 to ignore scripts. | ||
|
|
||
| val h1 = nodes.item(2) |
There was a problem hiding this comment.
| val h1 = nodes.item(2) | |
| val h1 = nodes.item(nodes.length - 2) |
| assertEquals("H1", h1.tagName.asInstanceOf[String]) | ||
| assertEquals("SeleniumJSEnv Test", h1.textContent.asInstanceOf[String]) | ||
|
|
||
| val canvas = elements(1) | ||
| val canvas = nodes.item(3) |
There was a problem hiding this comment.
| val canvas = nodes.item(3) | |
| val canvas = nodes.item(nodes.length - 1) |
It is not; notably it does not have all methods like `slice`. This surfaces in 2.13 where the implementation of takeRight uses `slice`.
- Drop 2.10 support - Update 2.12 version - Add 2.13 support
No description provided.