explicitly specify insertion-order feature in docs #4994
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added a commit
that referenced
this pull request
Mar 4, 2016
explicitly specify insertion-order feature in docs
|
thank you Dmytro! |
|
LGTM |
|
the claim we inserted here is actually false since 2.10, as per https://twitter.com/travisbrown/status/735201036873400321 but I think it should preserve order, as it did in 2.9, so I opened https://issues.scala-lang.org/browse/SI-9893. let's have any further discussion there |
|
Sorry, I didn't actually check it for mutable version as I didn't notice that unlike immutable one, there is no test for it: https://github.com/scala/scala/tree/2.12.x/test/junit/scala/collection/mutable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's based on this very minor pull request: #4788
Just added similar details for mutable version of
ListMap.P.S. Next time I'll try to not split that kind of minor changes into different PRs.