-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] SI-9375 add synthetic readResolve only for static modules #4757
Conversation
LGTM |
MiMa failed. The reason is that the synthetic
|
@retronym wdyt? |
I'd suggest to manually call |
Calling
gives
|
Moved it to RefChecks. Thanks Jason for the suggestion! |
For inner modules, the synthetic readResolve method would cause the module constructor to be invoked on de-serialization in certain situations. See the discussion in the ticket. Adds a comprehensive test around serializing and de-serializing modules.
LGTM |
[backport] SI-9375 add synthetic readResolve only for static modules
Backport of #4671 to 2.11.x
For inner modules, the synthetic readResolve method would cause the
module constructor to be invoked on de-serialization in certain
situations. See the discussion in the ticket.
Adds a comprehensive test around serializing and de-serializing
modules.