Fix path mangling for 'scala' shell script on MinGW/MSYS. #27

szeiger · 2011-12-05T11:37:07Z

No description provided.

@bridge

Merged revisions 24830-24831,24834-24862 via svnmerge from https://lampsvn.epfl.ch/svn-repos/scala/scala/trunk ........ r24830 | extempore | 2011-04-26 21:00:24 +0200 (Tue, 26 Apr 2011) | 1 line Some solid progress on the pattern matcher, no review. ........ r24831 | odersky | 2011-04-27 12:26:39 +0200 (Wed, 27 Apr 2011) | 1 line More bridges in collections. Review by prokopec. ........ r24834 | extempore | 2011-04-27 20:35:47 +0200 (Wed, 27 Apr 2011) | 1 line Fixed inversion of fsc's exit code, closes scala#4519 no review. ........ r24835 | extempore | 2011-04-27 20:36:04 +0200 (Wed, 27 Apr 2011) | 2 lines Fixed a booch I made in io.Position's positioning. Closes scala#4498, no review. ........ r24836 | extempore | 2011-04-27 20:36:16 +0200 (Wed, 27 Apr 2011) | 1 line A little cleanup on a repl command, no review. ........ r24837 | extempore | 2011-04-27 20:36:32 +0200 (Wed, 27 Apr 2011) | 5 lines Trying to fix the pattern matcher took me into the lambda lifter, and I made some changes which seemed sensible to me. I'm going to be a stickler about eliminating mutable maps which hold mutable listbuffers. I could use some confirmation that I didn't somehow break the world: review by dragos. ........ r24838 | extempore | 2011-04-27 20:36:47 +0200 (Wed, 27 Apr 2011) | 4 lines Trying out a different strategy for restoring terminal settings so we don't have a list of hardcoded terminal types. Now it saves the terminal settings on script start and restores those on exit. Closes scala#4170, review by rytz. ........ r24839 | extempore | 2011-04-28 01:49:27 +0200 (Thu, 28 Apr 2011) | 1 line Cleaned up some hopelessly atrophied documentation, no review. ........ r24840 | extempore | 2011-04-28 03:10:22 +0200 (Thu, 28 Apr 2011) | 4 lines Upgraded -d so you can output classes directly to a jar. Very (very) loosely based on a patch from dmharrah. Like dmharrah before me, I see little if any change in compile times, which I find difficult to explain. Closes scala#27, review by dmharrah. ........ r24841 | extempore | 2011-04-28 17:12:42 +0200 (Thu, 28 Apr 2011) | 5 lines Improvements to the AST browser contributed by Yuvi Masory. Uses Nimbus LAF when available and improves readability by padding components. Adds menu items and key bindings for expanding and contracting nodes, closing the browser and continuing compilation, and closing the browser and aborting. No review. ........ r24842 | extempore | 2011-04-28 18:23:45 +0200 (Thu, 28 Apr 2011) | 15 lines Improved the error message for another of the most common situations I hear about in newbieland. It could be taken further. If compilation fails due to an unimplemented abstract method, and there is a concrete method of the same name and arity, it will do a pairwise analysis of the parameters and attempt to further explain where you went off the beam if it feels it can do so sensibly. Such as in the test case: % scalac S.scala S.scala:1: error: class S needs to be abstract, since method g in class J of type (y: Int,z: java.util.List)Int is not defined (Note that java.util.List does not match java.util.List[String]. To implement a raw type, use java.util.List[_]) class S extends J { ^ one error found No review. ........ r24843 | extempore | 2011-04-28 18:26:05 +0200 (Thu, 28 Apr 2011) | 11 lines I wrote a warning when nullary methods return Unit. I wimped out of including it in this patch because we had about 200 of them, and that's what is fixed in this patch. I will add the warning to some kind of "-Xlint" feature after 2.9. This is motivated at least partly by the resolution of scala#4506, which indicates the distinction between "def foo()" and "def foo" will continue to jab its pointy stick into our eyes, so I believe we have a minimal duty of at least following our own advice about what they mean and not making a semirandom choice as to whether a method has parens or not. Review by community. ........ r24844 | odersky | 2011-04-29 13:07:56 +0200 (Fri, 29 Apr 2011) | 1 line Fixes scala#4525. No review. ........ r24845 | plocinic | 2011-04-29 16:27:35 +0200 (Fri, 29 Apr 2011) | 1 line remove now redundant check (see scala#4426). review by extempore ........ r24846 | plocinic | 2011-04-29 16:27:40 +0200 (Fri, 29 Apr 2011) | 1 line Closes scala#4457. Review by odersky ........ r24847 | odersky | 2011-04-29 17:35:37 +0200 (Fri, 29 Apr 2011) | 1 line Ignore type errors raised in later phases that are due to mismatching existentials. Quick fix to address lift build failures. Review by dragos. ........ r24848 | odersky | 2011-04-29 18:02:53 +0200 (Fri, 29 Apr 2011) | 1 line Second version of trying to avoid the lift crasher bug. ........ r24849 | odersky | 2011-04-29 18:13:31 +0200 (Fri, 29 Apr 2011) | 1 line Issuing warnings with detailed info when we encounter the lift crasher case. ........ r24850 | michelou | 2011-04-29 21:41:12 +0200 (Fri, 29 Apr 2011) | 2 lines removed legacy library code (package scala.mobile) ........ r24851 | extempore | 2011-04-29 22:13:10 +0200 (Fri, 29 Apr 2011) | 4 lines Fixing the pattern matcher regression I introduced between rc1 and rc2. Not done with this situation but at least I managed to boil out the big problem and keep my five closed pattern matcher tickets to boot. Closes scala#4523, no review. ........ r24852 | extempore | 2011-04-30 00:40:03 +0200 (Sat, 30 Apr 2011) | 1 line Making further unapply regressions less likely, no review. ........ r24853 | extempore | 2011-04-30 22:00:39 +0200 (Sat, 30 Apr 2011) | 3 lines After having to update the code for someone else, ran damarau levenshtein on trunk again. Patchwise, I guess correcting spelling errors in comments is about as safe as it gets. No review. ........ r24854 | extempore | 2011-04-30 22:01:00 +0200 (Sat, 30 Apr 2011) | 1 line Don't crash the pickler with erroneous types. Review by odersky. ........ r24855 | extempore | 2011-04-30 22:01:25 +0200 (Sat, 30 Apr 2011) | 4 lines Completely to my surprise, found that fixing all those sequence issues revealed that the pattern matcher can catch a lot more inexhaustive cases than it has been catching. Fixed most of the inexhaustive matches in the compiler, which had become a bit warnier. No review. ........ r24856 | extempore | 2011-04-30 22:01:48 +0200 (Sat, 30 Apr 2011) | 2 lines A few minor cleanups involving logging messages, assertion messages, compiler warnings, and other innocuous matters. No review. ........ r24857 | extempore | 2011-05-01 07:10:09 +0200 (Sun, 01 May 2011) | 2 lines Don't issue a deprecation warning if the deprecated method is being called from a bridge method. No review. ........ r24858 | extempore | 2011-05-01 07:10:58 +0200 (Sun, 01 May 2011) | 4 lines Since I don't want to commit anything "interesting" until we ship 2.9, a few uninteresting cleanups involving how types are printed, getting some debugging code in shape to prepare for the long winter ahead, etc. No review. ........ r24859 | extempore | 2011-05-01 07:43:05 +0200 (Sun, 01 May 2011) | 2 lines Realized how noisy the @deprecated-takes-two-arguments message was and quieted it down. Oh, and documented the arguments. No review. ........ r24860 | extempore | 2011-05-01 20:15:49 +0200 (Sun, 01 May 2011) | 7 lines Reducing the sbt launcher footprint by eliminating val references which go through the scala package object, since they lead to otherwise unnecessary classes becoming required at startup. Mostly this means library files with constructors like "Iterator.empty" or "Stream.continually" receive a direct import of that companion. The one slightly less than cosmetic change was moving the strange xml value "$scope" back into Predef, because otherwise I have to touch the xml code generation. No review. ........ r24861 | extempore | 2011-05-01 21:58:44 +0200 (Sun, 01 May 2011) | 2 lines Added a @bridge'd $scope back to scala package object for binary compat. No review. ........ r24862 | extempore | 2011-05-02 05:28:58 +0200 (Mon, 02 May 2011) | 4 lines Figuring it couldn't hurt if more people had a command of some of our binary compatibility impacting code, I went over the ModuleDef elimination with my clarify stick and made the machinery more transparent, to me anyway. Review by plocinic. ........

``` ⚡ cat sandbox/test.scala trait T { def m = v val v = 42 } class C extends T object Test { def main(args: Array[String]): Unit = { assert(new C().m == 42) } } /code/scala on topic/nuke-impl-classes* ⚡ qscalac -Xprint:fields,constructors,erasure,mixin sandbox/test.scala && qscala Test [[syntax trees at end of fields]] // test.scala package <empty> { abstract <sub_synth> trait T extends scala.AnyRef { <accessor> <sub_synth> def T$_setter_$v_=(x$1: Int): Unit; def /*T*/$init$(): Unit = { () }; def m: Int = T.this.v; <stable> <accessor> <sub_synth> def v: Int = 42 }; <sub_synth> class C extends AnyRef with T { override <stable> <accessor> def v: Int = C.this.v; private[this] val v: Int = _; override <accessor> def T$_setter_$v_=(x$1: Int): Unit = C.this.v = x$1; def <init>(): C = { C.super.<init>(); () } }; object Test extends scala.AnyRef { def <init>(): Test.type = { Test.super.<init>(); () }; def main(args: Array[String]): Unit = scala.Predef.assert(new C().m.==(42)) } } [[syntax trees at end of erasure]] // test.scala package <empty> { abstract <sub_synth> trait T extends Object { <accessor> <defaultmethod> <sub_synth> def T$_setter_$v_=(x$1: Int): Unit; def /*T*/$init$(): Unit = { () }; <defaultmethod> def m(): Int = T.this.v(); <stable> <accessor> <defaultmethod> <sub_synth> def v(): Int = 42 }; <sub_synth> class C extends Object with T { override <stable> <accessor> def v(): Int = C.this.v; private[this] val v: Int = _; override <accessor> def T$_setter_$v_=(x$1: Int): Unit = C.this.v = x$1; def <init>(): C = { C.super.<init>(); C.super./*T*/$init$(); () } }; <sub_synth> object Test extends Object { def <init>(): Test.type = { Test.super.<init>(); () }; def main(args: Array[String]): Unit = scala.Predef.assert(new C().m().==(42)) } } [[syntax trees at end of constructors]] // test.scala package <empty> { abstract <sub_synth> trait T extends Object { <accessor> <defaultmethod> <sub_synth> def T$_setter_$v_=(x$1: Int): Unit; <defaultmethod> def m(): Int = T.this.v(); <stable> <accessor> <defaultmethod> <sub_synth> def v(): Int; def /*T*/$init$(): Unit = { T.this.T$_setter_$v_=(42); () } }; <sub_synth> class C extends Object with T { override <stable> <accessor> def v(): Int = C.this.v; private[this] val v: Int = _; override <accessor> def T$_setter_$v_=(x$1: Int): Unit = C.this.v = x$1; def <init>(): C = { C.super.<init>(); C.super./*T*/$init$(); () } }; <sub_synth> object Test extends Object { def main(args: Array[String]): Unit = scala.Predef.assert(new C().m().==(42)); def <init>(): Test.type = { Test.super.<init>(); () } } } [[syntax trees at end of mixin]] // test.scala: tree is unchanged since constructors /code/scala on topic/nuke-impl-classes* ⚡ javap -c -classpath . T C Compiled from "test.scala" public interface T { public abstract void T$_setter_$v_$eq(int); public int m(); Code: 0: aload_0 1: invokeinterface #15, 1 // InterfaceMethod v:()I 6: ireturn public abstract int v(); public void $init$(); Code: 0: aload_0 1: bipush 42 3: invokeinterface #21, 2 // InterfaceMethod T$_setter_$v_$eq:(I)V 8: return } Compiled from "test.scala" public class C implements T { public int v(); Code: 0: aload_0 1: getfield #15 // Field v:I 4: ireturn public void T$_setter_$v_$eq(int); Code: 0: aload_0 1: iload_1 2: putfield #15 // Field v:I 5: return public C(); Code: 0: aload_0 1: invokespecial #24 // Method java/lang/Object."<init>":()V 4: aload_0 5: invokespecial #27 // Method T.$init$:()V 8: return } ```

This corrects an error in the change to the trait encoding in scala#5003: getters in traits should have empty bodies and be emitted as abstract. ``` % ~/scala/2.12.0-M4/bin/scalac sandbox/test.scala && javap -c T Compiled from "test.scala" public interface T { public abstract void T$_setter_$x_$eq(int); public int x(); Code: 0: aload_0 1: invokeinterface #15, 1 // InterfaceMethod x:()I 6: ireturn public int y(); Code: 0: aload_0 1: invokeinterface #20, 1 // InterfaceMethod y:()I 6: ireturn public void y_$eq(int); Code: 0: aload_0 1: iload_1 2: invokeinterface #24, 2 // InterfaceMethod y_$eq:(I)V 7: return public void $init$(); Code: 0: aload_0 1: bipush 42 3: invokeinterface #29, 2 // InterfaceMethod T$_setter_$x_$eq:(I)V 8: aload_0 9: bipush 24 11: invokeinterface #24, 2 // InterfaceMethod y_$eq:(I)V 16: return } % qscalac sandbox/test.scala && javap -c T Compiled from "test.scala" public interface T { public abstract void T$_setter_$x_$eq(int); public abstract int x(); public abstract int y(); public abstract void y_$eq(int); public static void $init$(T); Code: 0: aload_0 1: bipush 42 3: invokeinterface #21, 2 // InterfaceMethod T$_setter_$x_$eq:(I)V 8: aload_0 9: bipush 24 11: invokeinterface #23, 2 // InterfaceMethod y_$eq:(I)V 16: return public void $init$(); Code: 0: aload_0 1: invokestatic #27 // Method $init$:(LT;)V 4: return } ```

This corrects an error in the change to the trait encoding in scala#5003: getters in traits should have empty bodies and be emitted as abstract. ``` % ~/scala/2.12.0-M4/bin/scalac sandbox/test.scala && javap -c T Compiled from "test.scala" public interface T { public abstract void T$_setter_$x_$eq(int); public int x(); Code: 0: aload_0 1: invokeinterface #15, 1 // InterfaceMethod x:()I 6: ireturn public int y(); Code: 0: aload_0 1: invokeinterface #20, 1 // InterfaceMethod y:()I 6: ireturn public void y_$eq(int); Code: 0: aload_0 1: iload_1 2: invokeinterface #24, 2 // InterfaceMethod y_$eq:(I)V 7: return public void $init$(); Code: 0: aload_0 1: bipush 42 3: invokeinterface scala#29, 2 // InterfaceMethod T$_setter_$x_$eq:(I)V 8: aload_0 9: bipush 24 11: invokeinterface #24, 2 // InterfaceMethod y_$eq:(I)V 16: return } % qscalac sandbox/test.scala && javap -c T Compiled from "test.scala" public interface T { public abstract void T$_setter_$x_$eq(int); public abstract int x(); public abstract int y(); public abstract void y_$eq(int); public static void $init$(T); Code: 0: aload_0 1: bipush 42 3: invokeinterface #21, 2 // InterfaceMethod T$_setter_$x_$eq:(I)V 8: aload_0 9: bipush 24 11: invokeinterface #23, 2 // InterfaceMethod y_$eq:(I)V 16: return public void $init$(); Code: 0: aload_0 1: invokestatic scala#27 // Method $init$:(LT;)V 4: return } ```

Port scala#4737 and scala#4944

kdeclarative: add kf5-kpackage for dependency

fix scala#27: Add tasty-ci

Fix path mangling for 'scala' shell script on MinGW/MSYS.

2393d74

paulp merged commit 2393d74 into scala:master Dec 5, 2011

scabug mentioned this pull request Apr 7, 2017

BigDecimal should have movePointLeft and movePointRight methods scala/bug#4619

Closed

sjrd pushed a commit to sjrd/scala that referenced this pull request Aug 19, 2018

Merge pull request scala#27 from dotty-staging/port-4737

9dfe905

Port scala#4737 and scala#4944

da-liii pushed a commit to da-liii/scala that referenced this pull request Nov 11, 2018

Merge pull request scala#27 from vicamo/kdeclarative-5.8-add-kpackage

3c102af

kdeclarative: add kf5-kpackage for dependency

bishabosha added a commit to bishabosha/scala that referenced this pull request Jan 28, 2020

fix scala#27: Add tasty-ci

531e068

bishabosha added a commit to bishabosha/scala that referenced this pull request Jan 28, 2020

fix scala#27: Add tasty-ci

d3bbfab

bishabosha added a commit to bishabosha/scala that referenced this pull request Jan 28, 2020

Merge pull request scala#30 from scalacenter/tasty/ci

13353a3

fix scala#27: Add tasty-ci

lrytz pushed a commit that referenced this pull request Jul 7, 2020

fix #27: Add tasty-ci

afa94d5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix path mangling for 'scala' shell script on MinGW/MSYS. #27

Fix path mangling for 'scala' shell script on MinGW/MSYS. #27

szeiger commented Dec 5, 2011

Fix path mangling for 'scala' shell script on MinGW/MSYS. #27

Fix path mangling for 'scala' shell script on MinGW/MSYS. #27

Conversation

szeiger commented Dec 5, 2011