[nomerge] Support JDK 23 in optimizer (via upgrade to patched ASM 9.7.0) #10747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
the
prio:blocker
SethTisue
changed the title
SethTisue
force-pushed
the
update/asm-9.7-scala-2.12.x
branch
from
610dd8b to
abf726a
Compare
The ASM analyzer changed in 9.7 to no longer call `clearStack()` before `newExceptionValue`. We need to get the index of the exception value, which is always the first slot after all locals.
SethTisue
force-pushed
the
update/asm-9.7-scala-2.12.x
branch
from
7afeba9 to
5aa5189
Compare
|
Scabot isn't triggering. Lukas and/or I will fix it eventually. merging this on Travis-CI's say-so, so we can get community build runs going |
SethTisue
removed
the
prio:blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 2.12.x version of #10744.