Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Bump JLine 2 to 9a88bc4 #7952

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Dec 17, 2024

@SethTisue
Copy link
Member

SethTisue commented Dec 18, 2024

hmm, are we sure that removing jansi is a good idea in the JLine 2 context?

just asking; I don't remember why JLine 2 is even still present in this repo

@SethTisue
Copy link
Member

I see that JLine 2 is still present even on the develop branch, is that something we could or should clean up?

@Friendseeker
Copy link
Member Author

hmm, are we sure this is a good idea in a JLine 2 context?

just asking; I'm only dimly aware of why JLine 2 is even still present in this repo

I honestly have no clue too... At this point only Eugene and perhaps Lukas / som-snytt knows. Only thing I know is that some legacy Scala 2.12 sbt console support relies on JLine 2...

@Friendseeker
Copy link
Member Author

I see that JLine 2 is still present even on the develop branch, is that something we could or should clean up?

I mean thinking positively we all get to practice working with legacy code + unmaintained legacy dep!

@SethTisue
Copy link
Member

oh, Scala 2.12, sigh, that's plausible. still, I wonder if we should try ripping it out to verify if it's still needed

@eed3si9n
Copy link
Member

My guess is we'd need to support layered ClassLoader unless we drop the support of some Scala versions, which I don't think is worth it.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 4318b53 into sbt:1.10.x Dec 18, 2024
10 checks passed
@Friendseeker Friendseeker deleted the bump-jline-2 branch December 18, 2024 03:02
@SethTisue
Copy link
Member

unless we drop the support of some Scala versions, which I don't think is worth it.

it did cross my mind to try to convince you to drop support for building 2.12 projects 😈 but I'm not sure I could even convince myself, much as I would like to see 2.12 die

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants