Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoking an alias should display the original command #598

Closed
OlegYch opened this issue Nov 13, 2012 · 1 comment
Closed

Invoking an alias should display the original command #598

OlegYch opened this issue Nov 13, 2012 · 1 comment
Labels
Enhancement

Comments

@OlegYch
Copy link
Contributor

OlegYch commented Nov 13, 2012

E.g. if i have
alias gip= idea with-sources=yes sbt-classifiers

and invoke

gip

it should display

idea with-sources=yes sbt-classifiers

Otherwise it might be confusing if alias has an error
$ gip
[error] Expected whitespace character
[error] Not a valid project ID: gip
[error] Not a valid configuration: gip
[error] Not a valid key: gip (similar: skip)
[error] gip
[error] ^
@harrah
Copy link
Member

harrah commented Nov 15, 2012

This is reasonable, but requires some changes to the underlying parser combinator library. The parser library automatically generates errors based on the real input and there would have to be special support for switching the input context or something. I won't get to this soon, but can certainly help guide a pull request.

@harrah harrah closed this as completed in 1d9b44d Nov 24, 2013
harrah added a commit that referenced this issue Mar 21, 2014
@harrah @eed3si9n
Expand aliases instead of evaluating directly.
0e3b5a6 
This avoids an additional cause of recursion via the semicolon/multiple command, which fixes #933.
It also provides error messages on the expanded command.  This fixes #598.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harrah @OlegYch