-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export classpath no longer exports #1155
Comments
This appears to be related to the addition of the I'm still investigating, this is just a note so I don't forget. |
Hmm, was barking up the wrong tree. This commit is interesting: ca7e78d. |
It looks like we have more than one "export" stream per task run. That commit ensures the one we read from is closed before written to, although there is another file which DOES have the correct value in it. Going to figure out how to wire up to the correct export stream, then we should be good to go. |
Ok, the issue appears to be we're exporting things with the 'streams' key (associated with the fullClaspsath task), but we're reading from the 'fullClasspath' key, so the resulting stream is empty.
Lining up the keys in that way shows exactly the issue. |
Fixes #1155. It seems that somehow during the 0.13.{1 -> 2 } transition, we stopped pointing at the correct key for TaskKeys (either that or task streams are now all associated with the `streams` key). I think this may have been inadvertently caused from several refactorings to enable greater control over the execution of tasks. This points the `last*` methods at the correct key for tasks, fixing both `last <key>` and `export <key>` commands.
Found it. Will be fixed in the RC1. |
Great, thanks. |
Oh yeah - I saw there was a test which issued some command involving export classpath, and it has apparently not been failing. That might merit investigation in case it's not testing what it was written to test. |
Yeah, it was never testing what made it to System.out from the sbt process. We actually don't have hooks for those tests, so unfortunately the only way to test I'll be working the test suite slowly over the coming months for greater stability + a few more features so we can check things like "export". Ironically, the move to sbt-server makes checking System.out easy and a lot else harder. |
Fixes #1155. It seems that somehow during the 0.13.{1 -> 2 } transition, we stopped pointing at the correct key for TaskKeys (either that or task streams are now all associated with the `streams` key). I think this may have been inadvertently caused from several refactorings to enable greater control over the execution of tasks. This points the `last*` methods at the correct key for tasks, fixing both `last <key>` and `export <key>` commands.
Fixes sbt#1155. It seems that somehow during the 0.13.{1 -> 2 } transition, we stopped pointing at the correct key for TaskKeys (either that or task streams are now all associated with the `streams` key). I think this may have been inadvertently caused from several refactorings to enable greater control over the execution of tasks. This points the `last*` methods at the correct key for tasks, fixing both `last <key>` and `export <key>` commands.
In 0.13.1, given this build.sbt
Running sbt 'export fullClasspath' gives this:
In 0.13.2-M1 and -M2, it just exits silently.
The text was updated successfully, but these errors were encountered: