Generate an error when making a path string from paths containing the…

… separator. Fixes #1038. This is an attempt to provide a decent error message in some cases. However, paths that include the Java path separator character are just fundamentally problematic and aren't always going to be cleanly detected.
sbt · Mar 21, 2014 · 12d842f · 12d842f
1 parent e80a2b2
commit 12d842f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/util/io/src/main/scala/sbt/Path.scala b/util/io/src/main/scala/sbt/Path.scala
@@ -68,7 +68,11 @@ object Path extends PathExtra
 
 	def absolute(file: File): File = new File(file.toURI.normalize).getAbsoluteFile
 	def makeString(paths: Seq[File]): String = makeString(paths, pathSeparator)
-	def makeString(paths: Seq[File], sep: String): String = paths.map(_.getAbsolutePath).mkString(sep)
+	def makeString(paths: Seq[File], sep: String): String = {
+		val separated = paths.map(_.getAbsolutePath)
+		separated.find(_ contains sep).foreach( p => sys.error(s"Path '$p' contains separator '$sep'") )
+		separated.mkString(sep)
+	}
 	def newerThan(a: File, b: File): Boolean = a.exists && (!b.exists || a.lastModified > b.lastModified)
 
 	/** The separator character of the platform.*/