Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError: path 'share/applications/' cannot end with '/' #2099

Closed
cool-RR opened this issue Nov 1, 2023 · 6 comments
Closed

ValueError: path 'share/applications/' cannot end with '/' #2099

cool-RR opened this issue Nov 1, 2023 · 6 comments
Assignees

Comments

@cool-RR
Copy link
Contributor

cool-RR commented Nov 1, 2023

When attempting to install on Windows, I get the following error:

    File "C:\Program Files\Python311\Lib\site-packages\setuptools\_distutils\util.py", line 141, in convert_path
      raise ValueError("path '%s' cannot end with '/'" % pathname)
  ValueError: path 'share/applications/' cannot end with '/'

Full output.

Possibly this is caused by this line in setup.py:

      data_files=[('share/man/man1', ['visidata/man/vd.1', 'visidata/man/visidata.1']), ('share/applications/', ['visidata/desktop/visidata.desktop'])],

Maybe 'share/applications/' needs to be changed to 'share/applications'. Context.

@anjakefala
Copy link
Collaborator

anjakefala commented Nov 1, 2023

Hey @cool-RR,

Oh no! =( This should just silently no-op, not Exception like this.

Are you able to install VisiData from a branch if I give you the installation command? I'm going to need your help to figure out something that works. The challenge is that this setup.py needs to be able to work for multiple Operating Systems, and I have a Linux machine. I'll find a Mac person to help test, too.

Later today, I'll test removing the / on my machine, and push and ask you to check if it works for you (or at minimum silently does nothing).

Are you able to use an older version of VisiData in the meanwhile? Or to modify the setup.py locally and install?

@cool-RR
Copy link
Contributor Author

cool-RR commented Nov 1, 2023

Oh no! =( This should just silently no-op, not Exception like this.

Are you able to install VisiData from a branch if I give you the installation command?

Yes.

I'm going to need your help to figure out something that works. The challenge is that this setup.py needs to be able to work for multiple Operating Systems, and I have a Linux machine. I'll find a Mac person to help test, too.

Later today, I'll test removing the / on my machine, and push and ask you to check if it works for you (or at minimum silently does nothing).

Sounds good.

Are you able to use an older version of VisiData in the meanwhile?

Because VisiData doesn't work well on Windows anyway, I mostly use it only on Linux, so I'm okay with it not working on Windows for a while.

@anjakefala
Copy link
Collaborator

Okay, I ended up having time to test locally. Could you please try pip3 install git+https://github.com/saulpw/visidata.git@develop?

  1. Does it install without problem?
  2. If it does, can you search for the visidata.desktop file on your computer, and tell me if you found it installed somewhere?

@anjakefala
Copy link
Collaborator

cf5a628

@cool-RR
Copy link
Contributor Author

cool-RR commented Nov 1, 2023

It indeed installs without problem, thank you.

I couldn't find a file visidata.desktop on my C: drive. If there's any specific location you'd like me to specifically check, lemme know.

@anjakefala
Copy link
Collaborator

Great!

I couldn't find a file visidata.desktop on my C: drive. If there's any specific location you'd like me to specifically check, lemme know.

Yeah, I don't think you would have the manpage installed either. The problem is that data_files is not cross-platform by default. It also seems it is deprecated (https://discuss.python.org/t/should-there-be-a-new-standard-for-installing-arbitrary-data-files/7853/17).

I think that is a seperate problem though, which I will add to my list. I might message you for help with testing on Windows. Thanks!

(What it is supposed to do is install the visidata.desktop file such that you can right click on a .csv file, and specify that VisiData launches and loads it when you double-click.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants