Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle alpha units #1525

Closed
4 of 5 tasks
nex3 opened this issue Nov 15, 2014 · 5 comments
Closed
4 of 5 tasks

Properly handle alpha units #1525

nex3 opened this issue Nov 15, 2014 · 5 comments
Labels
CSS compatibility Support the CSS spec requires deprecation Blocked on a deprecation cycle specs written Specs have been written for the feature and at least one implementation passes them

Comments

@nex3
Copy link
Contributor

nex3 commented Nov 15, 2014 •
edited
Loading

Currently rgba() and hsla() completely ignore units on the $alpha argument. They should interpret percentages per spec and fail for any other unit.
@nex3 nex3 added CSS compatibility Support the CSS spec requires deprecation Blocked on a deprecation cycle labels Nov 15, 2014
nex3 added a commit that referenced this issue Nov 15, 2014
@nex3
Add a deprecation warning for using units in rgba/hsla alpha parameters.
85b3be9 
See #1525
@nex3 nex3 added this to the 4.0 milestone Aug 21, 2015
@nex3 nex3 removed this from the 4.0 milestone Jul 13, 2018
@nex3
Copy link
Contributor Author

nex3 commented Jul 13, 2018

This is handled correctly by Dart Sass, but it looks like it's still marked as TODO for LibSass.

@xzyfer Is there an issue tracking this on the LibSass side yet?

This was referenced Sep 20, 2018
Closed
Closed
@prakhar-pal
Copy link

prakhar-pal commented Sep 27, 2018 •
edited
Loading

The spec at http://dev.w3.org/csswg/css-color/#typedef-alpha-value says that percentages(0-100%) and number(0-1) are allowed for alpha argument.
My understanding from issue description is that it should fail when anything other than % are given as argument. So,
.card{ color: rgba(255,255,255,0.5); }
should fail, but
.card{ color: rgba(255,255,255,50%); }
should pass? Kindly clarify.

@nex3
Copy link
Contributor Author

nex3 commented Sep 27, 2018

@lawki These functions are intended to allow unitless numbers between 0 and 1 as well.

@prakhar-pal
Copy link

Got it, thanks.

nex3 added a commit to sass/sass-spec that referenced this issue Oct 15, 2018
@nex3
Add specs for alpha units in rgba() and hsla()
f6fe3a8 
See sass/sass#1525
@nex3 nex3 mentioned this issue Oct 15, 2018
Merged
@nex3 nex3 added the specs written Specs have been written for the feature and at least one implementation passes them label Oct 16, 2018
nex3 added a commit to sass/sass-spec that referenced this issue Oct 16, 2018
@nex3
Add specs for alpha units in rgba() and hsla() (#1291)
e922f22 
See sass/sass#1525
@digitalcitizenship digitalcitizenship mentioned this issue Jul 19, 2019
Merged
@jvhoven jvhoven mentioned this issue Sep 26, 2019
Merged
@nex3
Copy link
Contributor Author

nex3 commented Oct 26, 2020

Closing this out because LibSass is now deprecated and we aren't expecting to add any additional features to it.

@nex3 nex3 closed this as completed Oct 26, 2020
@pagopa-github-bot pagopa-github-bot mentioned this issue May 17, 2021
Merged
@artsy-peril artsy-peril bot mentioned this issue Jul 8, 2021
Merged
@artsy-peril artsy-peril bot mentioned this issue Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS compatibility Support the CSS spec requires deprecation Blocked on a deprecation cycle specs written Specs have been written for the feature and at least one implementation passes them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @prakhar-pal