This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Update watched file list when files are added or removed #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we build the Sass import graph when the CLI watcher is started. However the graph is not update updated when files are added or deleted. The latest is a big deal but the former results in new files not triggered rebuilds when they're changed. The only way to currently resolve this is to restart the CLI watcher. This patch rebuilds the Sass import graph when files are added or deleted to the watch always works as expected. Fixes sass#1538
|
AppVeyor failure is a false alarm. |
|
Unfortunately we don't have watcher tests atm because they were flakey in CI. Gonna test it in production 🙊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we build the Sass import graph when the CLI watcher is
started. However the graph is not update updated when files are
added or deleted. The latest is a big deal but the former results
in new files not triggered rebuilds when they're changed. The only
way to currently resolve this is to restart the CLI watcher.
This patch rebuilds the Sass import graph when files are added or
deleted to the watch always works as expected.
Fixes #1538