This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Attempt to fix AppVeyor tag race condition #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it's a bit of an ordeal trying to get the atomic puush required for AppVeyor to register a commit on the release branch and also a tag. Looks like AppVeyor expects you to do release from the master branch. Inspired by @nschonni work in sass#1518 in an attempt to work around this issue this PR instructs AppVeyor to ignore tags on non-release branches. Fingers crossed this makes like easier. Closes sass#1518
|
It was relatively less painful, but still not straight forward. |
|
It is actually not @appveyor's fault. Github invokes webhooks many times for one commit in a funny combination. I don't have the advice from the AppVeyor forum at hand, but there I think there was a way to adjust github webooks so that only the stuff we need is sent. |
|
That may be the case this release was significantly easier than in the past. This patch may not help but it doesn't hurt either. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's a bit of an ordeal trying to get the atomic puush
required for AppVeyor to register a commit on the release branch
and also a tag. Looks like AppVeyor expects you to do release from
the master branch.
Inspired by @nschonni work in #1518 in an attempt to work around
this issue this PR instructs AppVeyor to ignore tags on non-release
branches.
Fingers crossed this makes like easier.
Closes #1518