Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: touched vs. touche #2

Merged
merged 2 commits into from
Jun 12, 2019
Merged

test: touched vs. touche #2

merged 2 commits into from
Jun 12, 2019

Conversation

docwhat
Copy link
Contributor

@docwhat docwhat commented May 19, 2019

Some words shouldn't allow suffixes.

Fixes #1

@docwhat
Copy link
Contributor Author

docwhat commented May 19, 2019

@sapegin I wrote the tests to check this, but I can't figure out how to fix it just for touché and not break things like dopplegänger and its plural.

I suppose I could remove the [\w-]s check and the suffixes test and then manually add plurals to the word list?

@sapegin
Copy link
Owner

sapegin commented May 20, 2019

I suppose I could remove the [\w-]s check and the suffixes test and then manually add plurals to the word list?

Yeah, I think that would be the best approach.

Thanks for the PR!

@sapegin sapegin merged commit f59b2cf into sapegin:master Jun 12, 2019
@sapegin
Copy link
Owner

sapegin commented Jun 12, 2019

Thanks, merging! Sorry for the delay.

sapegin pushed a commit that referenced this pull request Jun 13, 2019
Changelog: 🚀
6c865f7 
## Breaking changes

* Minimum supported Node version is 8.6

## Bug fixes

* Only honor explicitly listed suffixes ([#2](#2)), closes [#1](#1)
sapegin pushed a commit that referenced this pull request Jun 14, 2019
Changelog: 🚀
dae4cd3 
## Breaking changes

* Minimum supported Node version is 8.6

## Bug fixes

* Only honor explicitly listed suffixes ([#2](#2)), closes [#1](#1)
@sapegin
Copy link
Owner

sapegin commented Jun 14, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"touchéd" is not the correct form of "touched"
2 participants
@docwhat @sapegin