Rename params with path_params #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansyrox
reviewed
Apr 4, 2023
There was a problem hiding this comment.
@carlosm27 , thank you for your PR but you may need to rebase it.
sansyrox
reviewed
Apr 4, 2023
CodSpeed Performance ReportMerging #460 Summary
|
sansyrox
force-pushed
the
main
branch
2 times, most recently
from
f0bf73a to
97e2c0c
Compare
sansyrox
reviewed
Apr 5, 2023
sansyrox
reviewed
Apr 5, 2023
sansyrox
previously approved these changes
Apr 6, 2023
There was a problem hiding this comment.
@carlosm27 , thanks for the updated PR but there is still one merge conflict. We will be able to hopefully merge it after that 😅
sansyrox
approved these changes
Apr 7, 2023
Thank you @sansyrox for guiding me and helping me through the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request address the proposal to rename
paramswithpath_params.This PR fixes #457