Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): fix hot reloading with dev flag #446

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(dev): fix hot reloading with dev flag #446

merged 1 commit into from
Mar 31, 2023

Conversation

AntoineRR
Copy link
Collaborator

Description

This PR fixes #439

The idea behind this PR is, when the dev flag is used, to:

  • Use the process run by the user to setup an observer and launch the server as a child process
  • When the observer detects a change in the directory, destroy all child processes and restart a new server
  • When a SIGINT is received, destroy both every child processes and the observer

@AntoineRR AntoineRR requested a review from sansyrox March 16, 2023 23:04
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #446 dev-flag-fix (33cc206) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 68 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

sansyrox
sansyrox reviewed Mar 17, 2023
View reviewed changes
robyn/reloader.py Outdated Show resolved Hide resolved
@sansyrox sansyrox force-pushed the main branch 4 times, most recently from ee6866d to 3ef0cdb Compare March 24, 2023 09:50
sansyrox
sansyrox reviewed Mar 27, 2023
View reviewed changes
robyn/__init__.py Outdated Show resolved Hide resolved
sansyrox
sansyrox reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AntoineRR 👋

Thanks for the PR 😄

I have some inline comments

sansyrox
sansyrox approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delays. I missed some important details here.

Great work as usual 🔥 🔥

@sansyrox sansyrox merged commit 403a9e4 into sparckles:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't access new or updated route while on dev option
2 participants
@AntoineRR @sansyrox