fix: return 500 status code when route raise #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
sansyrox
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Great work on the PR @AntoineRR 😄
I just have one suggestion 😄
Comment on lines
25
to
33
|
|
||
| def test_500_internal_server_error(session): | ||
| r = requests.get(f"{BASE_URL}/sync/raise") | ||
| assert r.status_code == 500 | ||
| r = requests.get(f"{BASE_URL}/async/raise") | ||
| assert r.status_code == 500 |
There was a problem hiding this comment.
Hey @AntoineRR ,
Let's split this test into two? It is easier to read the test logs and to use the pytest -k option to filter the tests
There was a problem hiding this comment.
That's a good point, fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #381