Revert "not not" deletion and add comment as to why that is there #31948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a non-related lint failure on this that is fixed in #31952 |
rallytime
pushed a commit
that referenced
this pull request
Mar 17, 2016
Revert "not not" deletion and add comment as to why that is there
| @@ -326,7 +326,8 @@ def upgrade_available(name): | |||
|
|
|||
| salt '*' pkg.upgrade_available <package name> | |||
| ''' | |||
| return latest_version(name) | |||
| # The "not not" tactic is intended here as it forces the return to be False. | |||
| return not not latest_version(name) # pylint: disable=C0113 | |||
There was a problem hiding this comment.
bool(name) would be more idiomatic. not not is only necessary if you're supporting Python versions older than 2.2.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment for more information.