Git hash 関連の環境変数をマクロ名に一致させる #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
reviewed
Oct 26, 2018
| @echo GIT_URL: %GIT_URL% | ||
| @echo GIT_SHORT_COMMIT_HASH : %GIT_SHORT_COMMIT_HASH% | ||
| @echo GIT_COMMIT_HASH : %GIT_COMMIT_HASH% | ||
| @echo GIT_URL : %GIT_URL% |
There was a problem hiding this comment.
レビューコメントですが、このPRとは関係ない話です。
ここの出力はこうなるんです↓
---- Make githash.h ----
GIT_SHORT_COMMIT_HASH : 5010d007
GIT_COMMIT_HASH : 5010d007bfb6d7fb74dc3e62f2a6fe257ee90066
GIT_URL : https://github.com/sakura-editor/sakura.git
APPVEYOR_URL : https://ci.appveyor.com
APPVEYOR_REPO_NAME : sakura-editor/sakurahttps://ci.appveyor.com/project/sakuraeditor/sakura/builds/19770675/job/2v09yiru7a1plb41
コロンの左側は長いものから短いものの順で並び、
コロンの右側は短いものから長いものの順で並んでいます。キレイです 💯
久しぶりにバッチのソースを見て、ここだけ並び順が違ってることに気付きました 👎
実際の処理手順はともかくとして、ドキュメントの記述順は合わせたいかなーと思いました。
ただ、それは今じゃなくてもいいと思ってます。
berryzplus
reviewed
Oct 26, 2018
| | COMMITID | git の commit Hash | git 環境が有効な場合 | | ||
| | SHORT_COMMITID | git の commit Hash の先頭8文字 | git 環境が有効な場合 | | ||
| | GIT_COMMIT_HASH | git の commit Hash | git 環境が有効な場合 | | ||
| | GIT_SHORT_COMMIT_HASH | git の commit Hash の先頭8文字 | git 環境が有効な場合 | |
There was a problem hiding this comment.
ドキュメントの書き順の指摘箇所はこの辺です。
出力順は、「短いやつ→長いやつ」なので。
berryzplus
reviewed
Oct 26, 2018
m-tmatma
force-pushed
the
feature/git-commit-hash-var
branch
from
6f1b6c2 to
c1f3433
Compare
単に違っているから合わせる、のが理由です。 |
|
d4779a9 で定義順を合わせました。 |
berryzplus
approved these changes
Oct 27, 2018
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…-hash-var Git hash 関連の環境変数をマクロ名に一致させる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#576: Git hash 関連の環境変数をマクロ名に一致させる
以下マクロに対応する環境変数名をマクロ名に合わせる