rmdir で削除対象のディレクトリパスをダブルクォートで囲む #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
approved these changes
Oct 21, 2018
There was a problem hiding this comment.
LGTMです。
いちおう m|\brmdir\s+|i でgrepしてエスケープ漏れがないことを確認しました。
□検索条件 "\brmdir\s+"
検索対象 *.*;!*.msi;!*.exe;!*.obj;!*.pdb;!*.ilk;!*.res;#.git;#.vs;#.svn;#Debug
フォルダ C:\gitroot\sakura
(サブフォルダも検索)
(英大文字小文字を区別しない)
(正規表現:bregonig.dll Ver.3.06 with Onigmo 5.15.0)
(文字コードセットの自動判別)
(一致した行を出力)
C:\gitroot\sakura\build-installer.bat(37,34) [SJIS]: if exist "%INSTALLER_WORK%" rmdir /s /q "%INSTALLER_WORK%"
C:\gitroot\sakura\build-installer.bat(38,34) [SJIS]: if exist "%INSTALLER_OUTPUT%" rmdir /s /q "%INSTALLER_OUTPUT%"
C:\gitroot\sakura\zipArtifacts.bat(172,2) [SJIS]: rmdir /s /q "%WORKDIR%"
C:\gitroot\sakura\zipArtifacts.bat(175,2) [SJIS]: rmdir /s /q "%WORKDIR_ASM%"
C:\gitroot\sakura\zipArtifacts.bat(267,2) [SJIS]: rmdir /s /q "%WORKDIR%"
C:\gitroot\sakura\zipArtifacts.bat(270,2) [SJIS]: rmdir /s /q "%WORKDIR_ASM%"
C:\gitroot\sakura\installer\sinst_src\keyword\bat.khp(33,69) [SJIS]: MKDIR,MDディレクトリを作ります.\n\nMKDIR [ﾄﾞﾗｲﾌﾞ:]ﾊﾟｽ\nMD [ﾄﾞﾗｲﾌﾞ:]ﾊﾟｽ\n\n関連項目:RMDIR
C:\gitroot\sakura\installer\sinst_src\keyword\batch.kwd(79,1) [SJIS]: RMDIR
C:\gitroot\sakura\installer\sinst_src\keyword\MortScript.khp(120,1) [SJIS]: RmDir /// ディレクトリを消去する
C:\gitroot\sakura\installer\sinst_src\keyword\MortScript2.kwd(122,1) [SJIS]: RmDir
C:\gitroot\sakura\installer\sinst_src\keyword\Perl.kwd(171,1) [SJIS]: rmdir
C:\gitroot\sakura\installer\sinst_src\keyword\php.khp(591,1) [SJIS]: rmdir /// int rmdir ( string dirname)\nディレクトリを削除する
C:\gitroot\sakura\installer\sinst_src\keyword\PHP.KWD(591,1) [SJIS]: rmdir
C:\gitroot\sakura\installer\sinst_src\keyword\Ruby.hkn(324,1) [SJIS]: rmdir
C:\gitroot\sakura\installer\sinst_src\keyword\vb2.kwd(44,1) [SJIS]: RmDir
C:\gitroot\sakura\tests\create-project.bat(14,2) [SJIS]: rmdir /s /q "%BUILDDIR%"
C:\gitroot\sakura\tools\zip\unzip.bat(5,21) [SJIS]: if exist "%OUTDIR%" rmdir /s /q "%OUTDIR%"
17 個が検索されました。
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
rmdir で削除対象のディレクトリパスをダブルクォートで囲む
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmdir で削除対象のディレクトリパスをダブルクォートで囲む
特に害はないが、念のため