Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doxygen コメントの @file をつける (take2) #564

Merged
merged 1 commit into from
Oct 21, 2018
Merged

doxygen コメントの @file をつける (take2) #564

merged 1 commit into from
Oct 21, 2018

Conversation

m-tmatma
Copy link
Member

#532, #535: doxygen コメントの @file をつける (take2)

@m-tmatma m-tmatma added document ドキュメント CI appveyor など CI 関連 【ChangeLog除外】 labels Oct 19, 2018
@m-tmatma m-tmatma added this to the next release milestone Oct 19, 2018
berryzplus
berryzplus approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

一点、sakura_core/sakura.hh に変更が入っているのが気になりました。
これは Help Compiler でコントロールIDを紐付けるのにも使うファイルなので C言語 コメントを入れていいものかどうかが分かりませんでした。appveyorのビルド結果を見る限り、とくに警告も出さずにコンパイルできているようなので問題ないんだな、と思っています。

なんかあったらまた対応するっていうことで、入れてしまいましょう。

@m-tmatma m-tmatma merged commit a198d13 into sakura-editor:master Oct 21, 2018
@m-tmatma m-tmatma deleted the feature/fix-doxygen-file-comment branch October 21, 2018 13:59
@m-tmatma m-tmatma mentioned this pull request Nov 6, 2018
Closed
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
Merge pull request sakura-editor#564 from m-tmatma/feature/fix-doxyge…
a5043f9 
…n-file-comment

doxygen コメントの @file をつける (take2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
CI appveyor など CI 関連 【ChangeLog除外】 document ドキュメント
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@m-tmatma @berryzplus