タイプ別設定画面のカラータブの色指定リストの背景色と前景色の色見本矩形の描画処理をDPIに合わせるように変更 #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
approved these changes
Sep 30, 2018
| rc1.bottom -= scaled2; | ||
|
|
||
| m_fgColorSampleLeft = rc1.left; | ||
| m_fgColorSampleRight = rc1.right; |
There was a problem hiding this comment.
一点懸念点があって、この新規追加の変数に値を設定しているのがここ（描画）だけで、
描画される前にクリックされる可能性はないと思うんですけど、
変数の初期化がないのが少し気になりました。
There was a problem hiding this comment.
（初期値を指定していない）グローバル変数は 0 初期化されますね。話は変わりますが本来は一行一行描画する度に計算する必要は無いんですが手抜きしています。
何か動作的に問題がある事が確認出たら対処するぐらいでも良いんじゃないかと思いますが、動作環境によっては思いもつかない不具合が出るかもしれないですね…。
|
Merge します。もし何か問題が見つかったら別 PR で対処しましょう。 |
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
タイプ別設定画面のカラータブの色指定リストの背景色と前景色の色見本矩形の描画処理をDPIに合わせるように変更
This was referenced Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
高DPIだと色指定リストの色見本矩形の横幅が狭くて選択しにくかったのを改善しました。
左端のチェック描画には手を入れていません。そこは個人的に困っていないので。
スクリーンショットを貼り付けます。