sakura_lang_en_US.dll の MinGW 向け Makefile を更新する #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
最近の修正に合わせて依存関係を修正。
berryzplus
changed the title
|
RCTOOLDIR と RCTOOLDIR の変更も削除しては? |
m-tmatma
reviewed
Aug 26, 2018
|
|
||
| depend: svnrev | ||
| depend: | ||
| $(CXX) -E -MM -w $(DEFINES) $(CXXFLAGS) *.cpp */*.cpp */*/*.cpp > depend.mak |
There was a problem hiding this comment.
この depend のルールいりますか?
おそらく不要ですが、cmakeが吐くMakefileに含まれています。（作る慣習がある？）
とりあえず「 svnrev に依存します」を除去するだけにとどめたいです。
これは #371 でやるんですね。 |
同じ変更内容なのでまとめてやるのが良いかなと考えて分けました。 |
m-tmatma
approved these changes
Aug 26, 2018
9 tasks
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…ang_dll_makefile sakura_lang_en_US.dll の MinGW 向け Makefile を更新する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
最近の修正に合わせてビルド方法を修正します。
#351 で sakura_core/Makefileに行った修正の横展開です。
#352 btool フォルダ削除 の前に実施すべき修正です。