githash.bat のエラー耐性を上げる #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 引数に / が含まれていても動くようにする - カレントディレクトリが意図していない場所になっていても動作するようにする
berryzplus
reviewed
Aug 25, 2018
sakura/githash.bat
Outdated
|
|
||
| @echo. | ||
| @echo ---- Make githash.h ---- | ||
|
|
||
| @rem ensure to be in the proper directory | ||
| pushd %~dp0 |
There was a problem hiding this comment.
%~dp0をダブルクォートで囲うべきだと思います。
ないとは思いますが C:\Documents and Settings\berryzplus\My Documents\sakuraにクローンした場合、
pushd C:\Documents と解釈されてエラーになる余地があります。
|
修正しました |
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…thash-bat githash.bat のエラー耐性を上げる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
githash.bat のエラー耐性を上げる