grep実行中はテキスト置換処理の進捗ダイアログ表示を抑制 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p実行中は表示しないように判定追加
berryzplus
previously approved these changes
Jul 3, 2018
|
動作確認OKです。チカチカ現象発生しなくなりました。 |
kobake
reviewed
Jul 4, 2018
sakura_core/CSearchAgent.cpp
Outdated
| if( NULL != ( hwndCancel = pCDlgCancel->DoModeless( ::GetModuleHandle( NULL ), NULL, IDD_OPERATIONRUNNING ) ) ){ | ||
| hwndProgress = ::GetDlgItem( hwndCancel, IDC_PROGRESS ); | ||
| Progress_SetRange( hwndProgress, 0, 101 ); | ||
| Progress_SetPos( hwndProgress, 0 ); |
There was a problem hiding this comment.
重箱の隅ですみませんが、ここの行の先頭に半角スペースが1文字挟まってます。それ以外は LGTM です。
There was a problem hiding this comment.
ご対応ありがとうございます。
今更気づいてしまったのですが、この半角スペース混入、この PR 以前から存在していたものでしたね。お手数おかけしました。
|
マ～ジします！ 今回は細かいところまで修正いただいちゃいましたが、この程度だったら微修正前の時点の状態でもマージしちゃって良かったかなーと今更反省してます。細かい修正は後からでもぜんぜん問題ないので。 個人的にはレビュアーとしてのこだわりよりもスピードを優先したいのが本音です。もちろん気づいた点の指摘はしていきますが。僕の姿勢は基本的に "Done is better than perfect." です。 |
Merged
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…GrepRunning grep実行中はテキスト置換処理の進捗ダイアログ表示を抑制
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#194 に対応しました。