プロジェクトファイルに含まれていないソースファイルを追加する #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
marked this pull request as ready for review
|
❌ Build sakura 1.0.3708 failed (commit 0b043a0280 by @kazasaku) |
|
✅ Build sakura 1.0.3709 completed (commit 09a6de4b58 by @kazasaku) |
berryzplus
approved these changes
Apr 26, 2021
このファイルはMinGW向けWindowsSDKの定義漏れ（？）を補う目的のもので、 |
|
レビューありがとうございます。 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
リポジトリに存在するソースコードのうち、プロジェクトファイルに追加されていないものを追加します。
カテゴリ
PR の背景
プロジェクトファイルに「 SShare_History.h 」が含まれていないため、VS 上で探せず不便です。
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
次のファイルが含まれていないので追加します。
sakura_core/basis/_com_raise_error.cpp （ #1533 にて追加）も含まれていませんが追加していません。
PR の影響範囲
テスト内容
テスト1
手順
関連 issue, PR
参考資料