（#1457 補遺）カスタムメニュー画面でも追加・挿入後に機能リストを送る処理を入れたい #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build sakura 1.0.3237 completed (commit 92450c9015 by @kasumikagari) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
共通設定画面には似たUIを持つ3つのページ（メインメニュー・カスタムメニュー・ツールバー）がありますが、追加・挿入ボタン押下後の動きがメインメニュー画面とその他2つで異なっています。
メインメニュー画面では一つ下の機能が自動的に選択されますが、他2つのページでは選択されません。
UIの挙動が一貫していませんので、メインメニュー画面の動きに合わせる方向でぜひ変更を加えたいと思っています。
ツールバー画面については #1457 で対処予定で、本PRはカスタムメニュー画面分の変更を含みます。
カテゴリ
同種のUIの挙動が一貫しないのは不具合であるような気がしますが、否定的な意見もあると思います。
仕様・動作説明
#1457 を参照ください。
テスト内容
テスト1
手順
PR の影響範囲
関連 issue, PR
#1457