Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniqueKey prop to fix snapshot issue #1362

Merged
merged 4 commits into from
Oct 17, 2021

Conversation

TheJaredWilcurt
Copy link
Contributor

Fixes #1360

@TheJaredWilcurt
Copy link
Contributor Author

I'm hoping this (or something equivalent) can be merged/released, it is blocking us from upgrading this dep at work.

@TheJaredWilcurt
Copy link
Contributor Author

@sagalbot I know you're working hard on Vue 3 stuff, but would it be possible to squeeze this in to a Vue 2 release?

@TheJaredWilcurt TheJaredWilcurt changed the title Add uniqueKey prop Add uniqueKey prop to fix issue Feb 16, 2021
@TheJaredWilcurt TheJaredWilcurt changed the title Add uniqueKey prop to fix issue Add uniqueKey prop to fix snapshot issue Mar 8, 2021
@sagalbot sagalbot merged commit bf8be2e into sagalbot:master Oct 17, 2021
@github-actions
Copy link

🎉 This PR is included in version 3.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sagalbot
Copy link
Owner

Hey @TheJaredWilcurt - sorry for the huge wait! I'm sure you've moved on from this issue by now, but just wanted to let you know that I adjusted the PR and moved uid from data into props. Should allow you to remove your workaround. Thanks for flagging!

@TheJaredWilcurt TheJaredWilcurt deleted the uid-bug branch December 10, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UID's break Jest snapshots
2 participants