fix: don't allow empty strings to be selected (#1595)

sagalbot · Feb 19, 2022 · 93c479e · 93c479e
1 parent 673e621
commit 93c479e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/Select.vue b/src/components/Select.vue
@@ -702,7 +702,7 @@ export default {
         value = this.$data._value
       }
 
-      if (value !== undefined && value !== null) {
+      if (value !== undefined && value !== null && value !== '') {
         return [].concat(value)
       }
 

diff --git a/tests/unit/Selecting.spec.js b/tests/unit/Selecting.spec.js
@@ -213,7 +213,7 @@ describe('VS - Selecting Values', () => {
     expect(Select.vm.selectedValue).toEqual(options)
   })
 
-  fit('can select a false boolean option', async () => {
+  it('can select a false boolean option', async () => {
     const Select = mountDefault({
       options: [false],
     })