#1175: Improve "enableHTML" for options #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-langstein
reviewed
Mar 8, 2021
| @@ -933,7 +933,9 @@ | |||
| $wrapper.addClass("form-check"); | |||
|
|
|||
| if (this.options.enableHTML && $(label).length > 0) { | |||
| $wrapper.append($(label)); | |||
| var $checkboxLabel = $('<label class="form-check-label" />'); | |||
| $checkboxLabel.html(label); | |||
There was a problem hiding this comment.
Für mich sieht das gerade so aus, als ob einem label ein label hinzugefügt wird. Passt das?
There was a problem hiding this comment.
label ist im Normalfall nur der Label-Text. Es könnte jedoch auch ein etwas komplexeres Label bestehend aus verschiedenen HTML-Elementen sein, dass hier verwendet wird. label ist vielleicht nicht die beste Benennung hier. Eventuell wäre sowas wie labelContent besser. Das kann ich bei mir lokal mal ändern, dann kommt es mit der nächsten Änderung rein.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.