Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ryanofsky/bitcoin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 58ff41e
Choose a base ref
...
head repository: ryanofsky/bitcoin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 05f9770
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 8, 2020

  1. doc: Clarify developer notes about constant naming 

    I'm pretty sure developer notes were intended to say constants should be upper
case and variables should be lower case, but right now they are ambiguous about
whether to write:

```c++
// foo.h
extern const int SYMBOL;

// foo.cpp
const int SYMBOL = 1;
```

or:

```c++
// foo.h
extern const int g_symbol;

// foo.cpp
const int g_symbol = 1;
```

First convention above is better than the second convention because it tells
you without having to look anything up that the value of `SYMBOL` will never
change at runtime. Also I've never seen any c++ project anywhere using the
second convention
    @ryanofsky
    ryanofsky committed Apr 8, 2020
    Copy the full SHA
    05f9770 View commit details
Loading