Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Move util::EMPTY_RANGE to usage spot #3685

Merged
merged 1 commit into from
May 6, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented May 5, 2024

Just a small code cleanup, the range is not actually empty (that'd be NSRange::new(0, 0)), rather, this behaviour is specific to markedRange and selectedRange.

  • Tested on all platforms changed

@madsmtm madsmtm added DS - macos S - maintenance Repaying technical debt labels May 5, 2024
@madsmtm madsmtm force-pushed the madsmtm/macos-empty-range branch from 1a19cbb to 3125987 Compare May 5, 2024 23:05
@kchibisov kchibisov force-pushed the madsmtm/macos-empty-range branch from 3125987 to 8a6e483 Compare May 6, 2024 14:30
@madsmtm madsmtm merged commit cb39ab2 into master May 6, 2024
52 checks passed
@madsmtm madsmtm deleted the madsmtm/macos-empty-range branch May 6, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - macos S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.

2 participants