Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parking_lot #1402

Closed
wants to merge 2 commits into from
Closed

Update parking_lot #1402

wants to merge 2 commits into from

Conversation

emilio
Copy link
Contributor

@emilio emilio commented May 3, 2022

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users (N/A)
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior (N/A)
  • Created or updated an example program if it would help users understand this functionality (N/A)

@emilio
Copy link
Contributor Author

emilio commented May 3, 2022

The formatting issue is unrelated to my change.

emilio added a commit to emilio/wgpu that referenced this pull request May 3, 2022
@emilio
Update parking_lot.
3bfe3a5 
There's this pending glutin PR:

  rust-windowing/glutin#1402

And winit, which has already updated but hasn't done a new release yet.
But I'm interested in updating these in Firefox, where we don't use
these, so this patch as-is would still be useful.
@emilio emilio mentioned this pull request May 3, 2022
Merged
emilio added a commit to emilio/wgpu that referenced this pull request May 3, 2022
@emilio
Update parking_lot.
20e9a87 
There's this pending glutin PR:

  rust-windowing/glutin#1402

And winit, which has already updated but hasn't done a new release yet.
But I'm interested in updating these in Firefox, where we don't use
these, so this patch as-is would still be useful.
@kchibisov
Copy link
Member

I'll bump parking_lot together with winit, after winit release, so they'll have a matching version.

Bumping glutin right now isn't really a good thing, so we'd have a missmatch of deps with winit.

@kchibisov kchibisov closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilio @kchibisov