Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impl PhfHash for integer slices #273

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

drewkett
Copy link
Contributor

@drewkett drewkett commented Nov 16, 2022

Currently it's impossible to use [u64; N] as a key type because that gets borrowed as an [u64] and there is no PhfHash implementation for non-u8 slice types.

Currently it's impossible to use `[u64; N]` as a type for example because that gets borrowed as an `[u64]` and there is no `PhfHash` implementation for that.
@drewkett drewkett force-pushed the impl-phf-hash-for-slices branch from 9f6f71f to 272f3d7 Compare November 16, 2022 18:21
@JohnTitor JohnTitor linked an issue Nov 17, 2022 that may be closed by this pull request
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, thanks!

@JohnTitor JohnTitor merged commit 757012b into rust-phf:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use [u64; 4] as key type
2 participants