Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure copied Cargo.lock is writable #98

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Ensure copied Cargo.lock is writable #98

merged 1 commit into from
Jan 25, 2021

Conversation

astro
Copy link

@astro astro commented Nov 13, 2020

Updated from #96:

If the path pointed to by XARGO_RUST_SRC contains read-only Cargo
lockfiles, then xbuild fails because the copies it makes and attempts to
modify are also read-only.

@astro astro force-pushed the writable-cargo-lock branch from a75bb56 to 12fa703 Compare November 13, 2020 20:15
phil-opp
phil-opp reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left two inline comments about the error handling, but otherwise this looks good to me.

src/sysroot.rs Outdated Show resolved Hide resolved
src/sysroot.rs Outdated Show resolved Hide resolved
@sbourdeauducq @astro
Ensure copied Cargo.lock is writable
8f597f3 
> If the path pointed to by XARGO_RUST_SRC contains read-only Cargo
> lockfiles, then xbuild fails because the copies it makes and attempts to
> modify are also read-only.
@astro astro force-pushed the writable-cargo-lock branch from 12fa703 to 8f597f3 Compare January 21, 2021 22:18
@astro
Copy link
Author

astro commented Jan 21, 2021

Thank you for your feedback. PR updated.

@phil-opp
Copy link
Member

Thanks!

@phil-opp phil-opp merged commit 5753165 into rust-osdev:master Jan 25, 2021
phil-opp added a commit that referenced this pull request Jan 25, 2021
@phil-opp
Update changelog for #98
91cf3b1
@phil-opp
Copy link
Member

Published as v0.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astro @phil-opp @sbourdeauducq