Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new option to the configuration table (#55) #56

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

parraman
Copy link

@parraman parraman commented Feb 11, 2020

Added the option panic_immediate_abort to the configuration table. If this option is set to true, then the core crate will be compiled with the feature panic_immediate_abort. This new option is derived from #55.

Fixes #55.

Added the option `panic_immediate_abort` to the configuration table. If
this option is set to `true`, then the `core` crate will be compiled
with the feature `panic_immediate_abort`.
@phil-opp
Copy link
Member

Thanks a lot! Have you tried whether it works for your use case?

@ascjones
Copy link

Hey good timing I need this too! Just tested this branch and it works for me as expected.

@parraman
Copy link
Author

Indeed! It works as expected: if set, a panic is basically lowered to a software exception (trap).

Thanks to you!

@phil-opp
Copy link
Member

Ok perfect! Thanks for testing.

@phil-opp phil-opp merged commit 6bd00e2 into rust-osdev:master Feb 11, 2020
phil-opp added a commit that referenced this pull request Feb 11, 2020
@phil-opp
Copy link
Member

Published as version 0.5.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building core with the feature panic_immediate_abort
3 participants