Add u128 feature for complete u128 compatibility #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to only be used in the formatting pieces, and there could we just use |
|
Implemented as suggested. The change does require absolute paths for custom types and type aliases. |
|
Oh right sorry I forgot about that :(, that's actually a pretty crucial reason for this feature. In that case I guess we'll have to stick with an unstable feature |
|
I will revert to my original PR. Any comments or suggestions? |
|
Looks like this may still be the requires-absolute-paths version? |
|
Thanks! |
|
#61 reimplements this in a different way that neither requires absolute paths nor a cfg to opt into u128 compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a u128 feature with a feature gated bitflags width type for use in the macro. Enables functionality like debug formatting of flags that exceed 64 bits. #56