-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to associated constants #24
Conversation
Yeah for now this crate builds on stable, so we'll have to wait for associated constants to be stable to merge this unfortunately. |
@tamird It seems like the |
This needs a rebase to pick up various changes made on master; I'll try to get to it this week. |
Rebased; probably won't pass until 1.20 is stable. |
Rebased again. Beyond the use of associated constants, this also uses compiletest, which requires nightly. Do we want to just remove the compile-fail test? |
The stable/beta builds seem to still be failing due to experimental features? |
Yes, I believe that's because this PR adds a dependency on compiletest, which requires nightly (see my last comment). Should I just remove the compile-fail tests? |
Removed compiletest; lmk if you'd like me to squash the commits, but this should be green now. |
👍 Thanks @tamird! |
Adapt to breaking change in bitflags: bitflags/bitflags#24.
Two problems with this:
I suppose this will need to wait until associated constants are stable.