-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running tests on on "stable" Rust #171
Conversation
a18cfb3
to
cf44b1b
Compare
Update: now executing
|
Thanks @Mart-Bogdan! This looks good to me. Let's go and change that |
…s version in place. Made Travis CI run all tests on almost all platforms, except oldest rustc 1.20 which is incompatible with compiletest_rs. Now all tests could be run locally without Nightly, and on more platforms in CI.
cf44b1b
to
87caf02
Compare
Good, @KodrAus I've fixed version. I've cloned code, was intending to implement serde_json serialization, but noticed that all tests aren't working on stable :-) But actually I've found macros overwhelming, I was expecting it to be procedural ones. |
Thanks @Mart-Bogdan!
Macros are a bit of a beast unto their own, aren't they. We don't use a procedural macro here mostly for legacy reasons. This crate has been around for a really long time and needs to stay working on older systems that don't support the stable procedural macros. For bors r+ |
171: Fix running tests on on "stable" Rust r=KodrAus a=Mart-Bogdan Currently all tests can be run only on nightly toolchain. This PR fixes this, by using compiletest_rs with feature "stable" which works on stable rust, as well as on Nightly. **P.S.** I wanted to make some use of cfg flags, but this solution seems working, despite loading but more packages then with nightly only. **P.P.S.** What about specifying exact version of **compiletest_rs**, like "0.3.18", which is current, to not break further builds/tests ? Co-authored-by: Bogdan Mart <mart.bogdan@gmail.com>
Build succeeded
|
Yep, I've seen existing Issue, and big problem is that it already serializes, using nested object, so this should be compatible :-) |
Currently all tests can be run only on nightly toolchain.
This PR fixes this, by using compiletest_rs with feature "stable" which works on stable rust, as well as on Nightly.
P.S. I wanted to make some use of cfg flags, but this solution seems working, despite loading but more packages then with nightly only.
P.P.S. What about specifying exact version of compiletest_rs, like "0.3.18", which is current, to not break further builds/tests ?