Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve zero value flag handling and documentation. #157

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Improve zero value flag handling and documentation. #157

merged 1 commit into from
Apr 30, 2018

Conversation

Alex-Addy
Copy link
Contributor

PR to resolve #151.

@Alex-Addy
Copy link
Contributor Author

This may not make for perfect zero flag resolution but it will at least provide some documentation. While the tests may or may not be correct they will at least prevent accidental changes to the behavior of zero value flags.

dtolnay
dtolnay approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 0797951 into bitflags:master Apr 30, 2018
@dtolnay
Copy link
Contributor

dtolnay commented Apr 30, 2018

I released 1.0.3 with this fix.

@Alex-Addy
Copy link
Contributor Author

Fantastic, I'm happy to be able to give back to such a useful library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitflags values of zero are considered always present
2 participants
@Alex-Addy @dtolnay