Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include example off docs.rs #156

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Don't include example off docs.rs #156

merged 1 commit into from
Apr 26, 2018

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Apr 26, 2018

This uses docs.rs metadata to specify the inclusion of the example, meaning that it doesn't have to be included by default.

Technically a [breaking-change], though... (though the module is specified as not public API)

dtolnay
dtolnay approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you. As you said, example_generated is not a public API so not a breaking change.

@dtolnay dtolnay merged commit a8cda09 into bitflags:master Apr 26, 2018
@CAD97 CAD97 deleted the patch-1 branch April 26, 2018 02:31
@dtolnay
Copy link
Contributor

dtolnay commented Apr 26, 2018

Published in 1.0.2. This drops compile time of the bitflags crate by itself from 0.41 seconds to 0.29 seconds on my machine, a 30% improvement. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAD97 @dtolnay