Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing #[inline] #136

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Adding missing #[inline] #136

merged 1 commit into from
Nov 12, 2017

Conversation

Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Nov 12, 2017

There are a few places that are missing #[inline]. This causes all() to produce inefficient code at runtime when the bitflags are defined in a separate crate.

dtolnay
dtolnay approved these changes Nov 12, 2017
View reviewed changes
Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 4afd947 into bitflags:master Nov 12, 2017
@dtolnay
Copy link
Contributor

dtolnay commented Nov 12, 2017

I published this in 1.0.1.

@Amanieu
Copy link
Contributor Author

Amanieu commented Nov 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amanieu @dtolnay