Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Deprecate rust-lang.rust #956

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Deprecate rust-lang.rust #956

merged 5 commits into from
Aug 12, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented May 21, 2022

Adds a notice to the extension name and readme as well as triggering a notification pop on start linking to the rust-analyzer marketplace pages.

image

cc rust-lang/rls#1776

@Veykril Veykril force-pushed the master branch 3 times, most recently from b0b7284 to 3eafd7d Compare May 21, 2022 11:23
@bjorn3
Copy link
Member

bjorn3 commented May 21, 2022

Could a similar message be put into rls itself for non-vscode users? That message should probably get tweaked a bit to not refer to the vscode extension id's though.

@Veykril
Copy link
Member Author

Veykril commented May 21, 2022

Ye given rls is lsp we should be able to send a notification via the LSP layer as well.

@lnicola
Copy link
Member

lnicola commented May 21, 2022

We might want a "don't show again" option, since some people will surely want to keep using RLS.

@Xanewok
Copy link
Member

Xanewok commented May 28, 2022

This will be updated shortly via #927 (comment) so I'd like to wait a couple of days for the official support, instead.

@ehuss
Copy link
Collaborator

ehuss commented May 28, 2022

@Xanewok Not sure if you've been following, but we have been discussing the deprecation at https://rust-lang.zulipchat.com/#narrow/stream/301329-t-devtools/topic/rls.20deprecation.

I tested the deprecation system added in the insiders build, and AFAICT it does not provide any sort of notification to the user. All I can see is that it grays out the extension in the search page, and removes the Install button.

And, FWIW, this PR shouldn't move forward until some time after the public notification. I am planning on posting a PR for that today.

@lnicola
Copy link
Member

lnicola commented Jul 1, 2022

vscode.rust is already marked as deprecated on the Marketplace, with a pretty decent UX:

image

And in the meanwhile, https://blog.rust-lang.org/2022/07/01/RLS-deprecation.html came out.

@Xanewok Xanewok merged commit 8dbe67d into rust-lang:master Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants