Update notify dependency to v6
#1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthri
force-pushed
the
update-notify-v6
branch
from
38210f0 to
adf7d1b
Compare
shadows-withal
approved these changes
Nov 29, 2023
|
@all-contributors please add @matthri for code |
|
I've put up a pull request to add @matthri! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
notifyto v6 and usesnotify-debouncer-minifor event debouncing.Please Note:
notify-debouncer-minidoes NOT distinguish different event kinds but also has fewer dependencies thannotify-debouncer-full.I don't think this is a problem in this case, but please let me know if you prefer the version where event kinds are explicitly checked, then I will happily update this PR.
PS: I think one could think about moving the event handling to a separate function, as the watch function is getting a bit complex. For easier review I tried not to do too much changes to the structure.
So I can do the refactoring in a follow up PR or include it in this one if you prefer it.
closes #1640