Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node id to hir id refactor #93438

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Conversation

spastorino
Copy link
Member

Related to #89278

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 28, 2022
@bors
Copy link
Contributor

bors commented Jan 28, 2022

⌛ Trying commit 4fed4eaf1f47808054a466a0ebfbc1ab43d05062 with merge aa96faefcac093683ce6ac76663721b8e8add3ce...

@bors
Copy link
Contributor

bors commented Jan 28, 2022

☀️ Try build successful - checks-actions
Build commit: aa96faefcac093683ce6ac76663721b8e8add3ce (aa96faefcac093683ce6ac76663721b8e8add3ce)

@rust-timer
Copy link
Collaborator

Queued aa96faefcac093683ce6ac76663721b8e8add3ce with parent 427eba2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (aa96faefcac093683ce6ac76663721b8e8add3ce): comparison url.

Summary: This benchmark run shows 204 relevant regressions 😿 to instruction counts.

  • Average relevant regression: 1.4%
  • Largest regression in instruction counts: 6.9% on incr-unchanged builds of match-stress-enum check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 29, 2022
@spastorino spastorino force-pushed the node_id_to_hir_id_refactor branch 2 times, most recently from 1af9011 to 8e079de Compare January 31, 2022 17:43
@spastorino spastorino marked this pull request as ready for review January 31, 2022 17:43
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 31, 2022
@bors
Copy link
Contributor

bors commented Jan 31, 2022

⌛ Trying commit 8e079de with merge c7c009da733590badf6d357d014b264d2116a76f...

@bors
Copy link
Contributor

bors commented Jan 31, 2022

☀️ Try build successful - checks-actions
Build commit: c7c009da733590badf6d357d014b264d2116a76f (c7c009da733590badf6d357d014b264d2116a76f)

@rust-timer
Copy link
Collaborator

Queued c7c009da733590badf6d357d014b264d2116a76f with parent 24b8bb1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c7c009da733590badf6d357d014b264d2116a76f): comparison url.

Summary: This benchmark run shows 47 relevant regressions 😿 to instruction counts.

  • Average relevant regression: 0.5%
  • Largest regression in instruction counts: 1.0% on incr-unchanged builds of match-stress-enum check

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 1, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Feb 1, 2022

OK, the hash map is clearly visible in perf... before we do anything fancy, can you try just using a vec map or even a btreemap?

@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 1, 2022
@bors
Copy link
Contributor

bors commented Feb 1, 2022

⌛ Trying commit 6c0fdf0ed39afdef9af32d3a0f4c296f6a6f8064 with merge 329ad690a748dafcb9b572adf1e1a5aaa902a576...

@spastorino spastorino force-pushed the node_id_to_hir_id_refactor branch 2 times, most recently from 552c589 to cbfa7ce Compare February 21, 2022 13:47
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2022
@bors
Copy link
Contributor

bors commented Feb 21, 2022

⌛ Trying commit cbfa7ce with merge b79b1d9741593752d8ab835d5e0d7af5c767c677...

@bors
Copy link
Contributor

bors commented Feb 21, 2022

☀️ Try build successful - checks-actions
Build commit: b79b1d9741593752d8ab835d5e0d7af5c767c677 (b79b1d9741593752d8ab835d5e0d7af5c767c677)

@rust-timer
Copy link
Collaborator

Queued b79b1d9741593752d8ab835d5e0d7af5c767c677 with parent a924ef7, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b79b1d9741593752d8ab835d5e0d7af5c767c677): comparison url.

Summary: This benchmark run shows 11 relevant regressions 😿 to instruction counts.

  • Average relevant regression: 0.7%
  • Largest regression in instruction counts: 1.3% on full builds of deep-vector opt

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2022
@spastorino spastorino force-pushed the node_id_to_hir_id_refactor branch from 5e63ed3 to d82a7bc Compare February 22, 2022 12:37
@oli-obk
Copy link
Contributor

oli-obk commented Feb 23, 2022

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Feb 23, 2022

📌 Commit d82a7bc has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022
@bors
Copy link
Contributor

bors commented Feb 24, 2022

⌛ Testing commit d82a7bc with merge 8ebec97...

@bors
Copy link
Contributor

bors commented Feb 24, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 8ebec97 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2022
@bors bors merged commit 8ebec97 into rust-lang:master Feb 24, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 24, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8ebec97): comparison url.

Summary: This benchmark run did not return any relevant results. 54 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@rustbot rustbot removed the perf-regression Performance regression. label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants