-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node id to hir id refactor #93438
Node id to hir id refactor #93438
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4fed4eaf1f47808054a466a0ebfbc1ab43d05062 with merge aa96faefcac093683ce6ac76663721b8e8add3ce... |
☀️ Try build successful - checks-actions |
Queued aa96faefcac093683ce6ac76663721b8e8add3ce with parent 427eba2, future comparison URL. |
Finished benchmarking commit (aa96faefcac093683ce6ac76663721b8e8add3ce): comparison url. Summary: This benchmark run shows 204 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
1af9011
to
8e079de
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 8e079de with merge c7c009da733590badf6d357d014b264d2116a76f... |
☀️ Try build successful - checks-actions |
Queued c7c009da733590badf6d357d014b264d2116a76f with parent 24b8bb1, future comparison URL. |
Finished benchmarking commit (c7c009da733590badf6d357d014b264d2116a76f): comparison url. Summary: This benchmark run shows 47 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
OK, the hash map is clearly visible in perf... before we do anything fancy, can you try just using a vec map or even a btreemap? |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 6c0fdf0ed39afdef9af32d3a0f4c296f6a6f8064 with merge 329ad690a748dafcb9b572adf1e1a5aaa902a576... |
552c589
to
cbfa7ce
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit cbfa7ce with merge b79b1d9741593752d8ab835d5e0d7af5c767c677... |
☀️ Try build successful - checks-actions |
Queued b79b1d9741593752d8ab835d5e0d7af5c767c677 with parent a924ef7, future comparison URL. |
Finished benchmarking commit (b79b1d9741593752d8ab835d5e0d7af5c767c677): comparison url. Summary: This benchmark run shows 11 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
5e63ed3
to
d82a7bc
Compare
@bors r+ rollup=never |
📌 Commit d82a7bc has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8ebec97): comparison url. Summary: This benchmark run did not return any relevant results. 54 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Related to #89278
r? @oli-obk