r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

Then let's wait until the perf check is merged (otherwise the change looks good). Marking it as blocked.

Then let's wait until the perf check is merged (otherwise the change looks good). Marking it as blocked.

It's been open for several months :/ I don't know if it will be merged at all.

I want to actually be able to follow the perf changes as much as possible. What do we need to do in order to make it merged faster?

I want to actually be able to follow the perf changes as much as possible. What do we need to do in order to make it merged faster?

rust-lang/rustc-perf#802 (comment)

Apparently it's "close" to getting merge. If there's still no update in a week, let's maybe ask @Mark-Simulacrum directly about it. :)

rust-lang/rustc-perf#802 was merged.

@bors try @rust-timer queue

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

⌛ Trying commit f8b15d8 with merge 631b9863b1cf0df0e5f955ea5332af802c96df78...

☀️ Try build successful - checks-actions
Build commit: 631b9863b1cf0df0e5f955ea5332af802c96df78 (631b9863b1cf0df0e5f955ea5332af802c96df78)

Queued 631b9863b1cf0df0e5f955ea5332af802c96df78 with parent 3aedcf0, future comparison URL.

Finished benchmarking try commit (631b9863b1cf0df0e5f955ea5332af802c96df78): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

Wow, that is a surprisingly large difference, I only expected it to show up for big crates.

otherwise the change looks good

@bors r=GuillaumeGomez

📌 Commit f8b15d8 has been approved by GuillaumeGomez

⌛ Testing commit f8b15d8 with merge 50489e3...

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 50489e3 to master...