Fix links in RELEASES.md for 1.10.0 through 1.12.0 #41613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many links in this series have the `[link text]` and `(url)` on separate lines, which doesn't get correctly interpreted in markdown. Or maybe it once did, but it doesn't now. This patch joins the lines together.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
If you don't like the length of the joined lines, another alternative that still avoids spurious whitespace is to use HTML comments: A better change is to use out-of-line urls like all the other versions do, but that's a very manual process. |
|
Awesome, thanks! @bors: r+ rollup |
|
📌 Commit e8c4b7a has been approved by |
|
I wonder if this is involved in GitHub Flavored Markdown moving to
CommonMark, which is funny given our own recent situation with rustdoc...
|
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 29, 2017
Fix links in RELEASES.md for 1.10.0 through 1.12.0 Many links in this series have the `[link text]` and `(url)` on separate lines, which doesn't get correctly interpreted in markdown. Or maybe it once did, but it doesn't now. This patch joins the lines together. Here is the content rendered [before](https://github.com/rust-lang/rust/blob/2971d491b955fd8bb504c8ca675b8116b8b1550e/RELEASES.md#version-1120-2016-09-29) and [after](https://github.com/cuviper/rust/blob/e8c4b7af216c9e035b40f78cbd77a35614fdc240/RELEASES.md#version-1120-2016-09-29).
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 30, 2017
Fix links in RELEASES.md for 1.10.0 through 1.12.0 Many links in this series have the `[link text]` and `(url)` on separate lines, which doesn't get correctly interpreted in markdown. Or maybe it once did, but it doesn't now. This patch joins the lines together. Here is the content rendered [before](https://github.com/rust-lang/rust/blob/2971d491b955fd8bb504c8ca675b8116b8b1550e/RELEASES.md#version-1120-2016-09-29) and [after](https://github.com/cuviper/rust/blob/e8c4b7af216c9e035b40f78cbd77a35614fdc240/RELEASES.md#version-1120-2016-09-29).
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 30, 2017
Fix links in RELEASES.md for 1.10.0 through 1.12.0 Many links in this series have the `[link text]` and `(url)` on separate lines, which doesn't get correctly interpreted in markdown. Or maybe it once did, but it doesn't now. This patch joins the lines together. Here is the content rendered [before](https://github.com/rust-lang/rust/blob/2971d491b955fd8bb504c8ca675b8116b8b1550e/RELEASES.md#version-1120-2016-09-29) and [after](https://github.com/cuviper/rust/blob/e8c4b7af216c9e035b40f78cbd77a35614fdc240/RELEASES.md#version-1120-2016-09-29).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many links in this series have the
[link text]and(url)on separatelines, which doesn't get correctly interpreted in markdown. Or maybe it
once did, but it doesn't now. This patch joins the lines together.
Here is the content rendered before and after.