Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codegen test for elidings bounds check when indexes are manually checked #134892

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

alex
Copy link
Member

@alex alex commented Dec 29, 2024

Closes #55147

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2024
@durin42
Copy link
Contributor

durin42 commented Dec 29, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 29, 2024

📌 Commit dab1c57 has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 29, 2024
Added codegen test for elidings bounds check when indexes are manually checked

Closes rust-lang#55147
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 29, 2024
Added codegen test for elidings bounds check when indexes are manually checked

Closes rust-lang#55147
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#134865 (bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros)
 - rust-lang#134884 (Fix typos)
 - rust-lang#134892 (Added codegen test for elidings bounds check when indexes are manually checked)
 - rust-lang#134894 (Document how to run the split Docker pipelines)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#134870 (Fix sentence fragment in `pin` module docs)
 - rust-lang#134884 (Fix typos)
 - rust-lang#134892 (Added codegen test for elidings bounds check when indexes are manually checked)
 - rust-lang#134894 (Document how to run the split Docker pipelines)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 96c44ef into rust-lang:master Dec 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 30, 2024
@alex alex deleted the codegen-55147 branch December 30, 2024 01:57
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2024
Rollup merge of rust-lang#134892 - alex:codegen-55147, r=durin42

Added codegen test for elidings bounds check when indexes are manually checked

Closes rust-lang#55147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to elide bound checks for multiple slice writes by index after length check that can't overflow
5 participants