bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros #134865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
rustbot
added
A-testsuite
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
proc-macro-tls
branch
from
8ce1957 to
af9a93b
Compare
onur-ozkan
reviewed
Dec 29, 2024
onur-ozkan
reviewed
Dec 29, 2024
rust-cloud-vms
bot
force-pushed
the
proc-macro-tls
branch
from
af9a93b to
f3b555e
Compare
bjorn3
reviewed
Dec 29, 2024
bjorn3
reviewed
Dec 29, 2024
rust-cloud-vms
bot
force-pushed
the
proc-macro-tls
branch
from
f3b555e to
fc73cfe
Compare
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2024
…zkan bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros Fixes rust-lang#134863 1. Checks if a crate name is in a static list before applying the flag 2. Adds a tidy check that gathers transitive deps of proc macros and ensures the list is up to date cc `@bjorn3` - the issue specifies `rustc_fluent_macro` but I assume this applies to all proc macro crates.
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 29, 2024
…zkan bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros Fixes rust-lang#134863 1. Checks if a crate name is in a static list before applying the flag 2. Adds a tidy check that gathers transitive deps of proc macros and ensures the list is up to date cc ``@bjorn3`` - the issue specifies `rustc_fluent_macro` but I assume this applies to all proc macro crates.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#134865 (bootstrap: Don't apply -Ztls-model=initial-exec to deps of proc-macros) - rust-lang#134884 (Fix typos) - rust-lang#134892 (Added codegen test for elidings bounds check when indexes are manually checked) - rust-lang#134894 (Document how to run the split Docker pipelines) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors r- |
bors
added
S-waiting-on-author
lqd
reviewed
Dec 29, 2024
rust-cloud-vms
bot
force-pushed
the
proc-macro-tls
branch
from
fc73cfe to
f073462
Compare
|
@bors r=onur-ozkan |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c156614): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 759.369s -> 759.791s (0.06%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134863
cc @bjorn3 - the issue specifies
rustc_fluent_macrobut I assume this applies to all proc macro crates.