Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement int_from_ascii (#134821) #134824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement int_from_ascii (#134821) #134824

wants to merge 1 commit into from
+139 −93

Conversation

niklasf
Copy link
Contributor

@niklasf niklasf commented Dec 27, 2024

Provides unstable T::from_ascii() and T::from_ascii_radix() for integer types T, as drafted in tracking issue #134821.

To deduplicate documentation without additional macros, implementations of isize and usize no longer delegate to equivalent integer types. After #132870 they are inlined anyway.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2024

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 27, 2024
@niklasf niklasf mentioned this pull request Dec 27, 2024
Open
5 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@niklasf
Implement int_from_ascii (rust-lang#134821)
7d0518c 
Provides unstable `T::from_ascii()` and `T::from_ascii_radix()` for integer
types `T`, as drafted in tracking issue rust-lang#134821.

To deduplicate documentation without additional macros, implementations of
`isize` and `usize` no longer delegate to equivalent integer types.
After rust-lang#132870 they are inlined anyway.
@ibraheemdev
Copy link
Member

This looks good. Just to make sure that the explicit inlining doesn't affect anything
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 16, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
@bors
Auto merge of rust-lang#134824 - niklasf:int_from_ascii, r=<try>
8ac1775 
Implement `int_from_ascii` (rust-lang#134821)

Provides unstable `T::from_ascii()` and `T::from_ascii_radix()` for integer types `T`, as drafted in tracking issue rust-lang#134821.

To deduplicate documentation without additional macros, implementations of `isize` and `usize` no longer delegate to equivalent integer types. After rust-lang#132870 they are inlined anyway.
@bors
Copy link
Contributor

bors commented Jan 16, 2025

⌛ Trying commit 7d0518c with merge 8ac1775...

@bors
Copy link
Contributor

bors commented Jan 16, 2025

☀️ Try build successful - checks-actions
Build commit: 8ac1775 (8ac17751217e45558eed8ba57f1cc4944b85e166)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8ac1775): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 0.2% [0.2%, 0.2%] 4
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-0.4%, 0.7%] 2

Max RSS (memory usage)

Results (primary 0.5%, secondary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.7% [4.1%, 5.4%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.7% [-4.6%, -2.7%] 2
Improvements ✅
(secondary)		 -1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) 0.5% [-4.6%, 5.4%] 4

Cycles

Results (primary 0.9%, secondary 3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)		 9.8% [9.8%, 9.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Binary size

Results (primary 0.0%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.2%] 13
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 38
Improvements ✅
(primary)		 -0.0% [-0.1%, -0.0%] 10
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 4
All ❌✅ (primary) 0.0% [-0.1%, 0.2%] 23

Bootstrap: 762.718s -> 763.43s (0.09%)
Artifact size: 326.06 MiB -> 326.13 MiB (0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@niklasf @rustbot @rust-log-analyzer @ibraheemdev @rust-timer @bors